Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 30 Oct 2017 20:00:46 -0400
From: Steven Rostedt <>
To: "Tobin C. Harding" <>
Cc:, "Jason A. Donenfeld"
 <>, Theodore Ts'o <>, Linus Torvalds
 <>, Kees Cook <>, Paolo
 Bonzini <>, Tycho Andersen <>, "Roberts,
 William C" <>, Tejun Heo <>, Jordan
 Glover <>, Greg KH
 <>, Petr Mladek <>, Joe Perches
 <>, Ian Campbell <>, Sergey Senozhatsky
 <>, Catalin Marinas <>,
 Will Deacon <>, Chris Fries <>, Dave
 Weinstein <>, Daniel Micay <>, Djalal
 Harouni <>,
Subject: Re: [PATCH V8 2/2] printk: hash addresses printed with %p

On Tue, 31 Oct 2017 09:41:02 +1100
"Tobin C. Harding" <> wrote:

> Cool. So I think we need
>  	get_random_bytes(&ptr_key, sizeof(ptr_key));

You'll need to add a comment here to describe what ordering the memory
barrier is used against. That is, somewhere else there's something that
needs to see the "true" after the "get_random_bytes" update. Describe
it here.

-- Steve

> 	smp_mb();
>  	WRITE_ONCE(have_filled_random_ptr_key, true);
> V10 to include this unless I have it wrong.
> thanks,
> Tobin.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.