Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 31 May 2017 13:13:09 +0200
From: Peter Zijlstra <>
To: Kees Cook <>
Cc:, Christoph Hellwig <>,
	"Eric W. Biederman" <>,
	Andrew Morton <>,
	Josh Poimboeuf <>,
	PaX Team <>, Jann Horn <>,
	Eric Biggers <>,
	Elena Reshetova <>,
	Hans Liljestrand <>,
	David Windsor <>,
	Greg KH <>,
	Ingo Molnar <>,
	Alexey Dobriyan <>,
	"Serge E. Hallyn" <>,,
	Davidlohr Bueso <>,
	Manfred Spraul <>,
	"" <>,
	James Bottomley <>,
	"" <>, Ingo Molnar <>,
	Arnd Bergmann <>,
	"David S. Miller" <>,
	Rik van Riel <>,
	linux-arch <>,
	"" <>
Subject: Re: [PATCH v5 2/3] x86/asm: Add suffix macro for GEN_*_RMWcc()

On Tue, May 30, 2017 at 02:39:51PM -0700, Kees Cook wrote:
> The coming x86 refcount protection needs to be able to add trailing
> instructions to the GEN_*_RMWcc() operations. This extracts the
> difference between the goto/non-goto cases so the helper macros
> can be defined outside the #ifdef cases. Additionally adds argument
> naming to the resulting asm for referencing from suffixed
> instructions, and adds clobbers for "cc", and "cx" to let suffixes
> use _ASM_CX, and retain any set flags.

Another option is to simply require __GCC_ASM_FLAG_OUTPUT__ for the fast
refcount stuff. That would result in simpler and more readable code.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.