Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 15 Aug 2022 13:54:25 -0400
From: Rich Felker <dalias@...c.org>
To: √Črico Nogueira <ericonr@...root.org>
Cc: musl@...ts.openwall.com
Subject: Re: [PATCH] remove extraneous syscall from fopen(3)

On Mon, Aug 15, 2022 at 02:50:21PM -0300, √Črico Nogueira wrote:
> the __fdopen() call afterwards will set the close-on-exec flag with the
> same syscall if "e" was specified in mode
> ---
>  src/stdio/fopen.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/stdio/fopen.c b/src/stdio/fopen.c
> index e1b91e12..22b72edf 100644
> --- a/src/stdio/fopen.c
> +++ b/src/stdio/fopen.c
> @@ -20,8 +20,6 @@ FILE *fopen(const char *restrict filename, const char *restrict mode)
>  
>  	fd = sys_open(filename, flags, 0666);
>  	if (fd < 0) return 0;
> -	if (flags & O_CLOEXEC)
> -		__syscall(SYS_fcntl, fd, F_SETFD, FD_CLOEXEC);
>  
>  	f = __fdopen(fd, mode);
>  	if (f) return f;
> -- 
> 2.37.2

See commit 7765706c0584ed4a30e0b7a3ada742e490ef02b0

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.