Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Mon, 15 Aug 2022 14:50:21 -0300
From: √Črico Nogueira <>
Cc: √Črico Nogueira <>
Subject: [PATCH] remove extraneous syscall from fopen(3)

the __fdopen() call afterwards will set the close-on-exec flag with the
same syscall if "e" was specified in mode
 src/stdio/fopen.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/stdio/fopen.c b/src/stdio/fopen.c
index e1b91e12..22b72edf 100644
--- a/src/stdio/fopen.c
+++ b/src/stdio/fopen.c
@@ -20,8 +20,6 @@ FILE *fopen(const char *restrict filename, const char *restrict mode)
 	fd = sys_open(filename, flags, 0666);
 	if (fd < 0) return 0;
-	if (flags & O_CLOEXEC)
-		__syscall(SYS_fcntl, fd, F_SETFD, FD_CLOEXEC);
 	f = __fdopen(fd, mode);
 	if (f) return f;

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.