[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20210602114617.423521-1-arnd@kernel.org>
Date: Wed, 2 Jun 2021 13:46:17 +0200
From: Arnd Bergmann <arnd@...nel.org>
To: stable@...r.kernel.org
Cc: Michael Weiser <michael.weiser@....de>,
Martin Vajnar <martin.vajnar@...il.com>,
musl@...ts.openwall.com,
Will Deacon <will.deacon@....com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Arnd Bergmann <arnd@...db.de>
Subject: [PATCH] [stable v4.1] arm64: Remove unimplemented syscall log message
From: Michael Weiser <michael.weiser@....de>
commit 1962682d2b2fbe6cfa995a85c53c069fadda473e upstream.
Stop printing a (ratelimited) kernel message for each instance of an
unimplemented syscall being called. Userland making an unimplemented
syscall is not necessarily misbehaviour and to be expected with a
current userland running on an older kernel. Also, the current message
looks scary to users but does not actually indicate a real problem nor
help them narrow down the cause. Just rely on sys_ni_syscall() to return
-ENOSYS.
Cc: <stable@...r.kernel.org>
Cc: Martin Vajnar <martin.vajnar@...il.com>
Cc: musl@...ts.openwall.com
Acked-by: Will Deacon <will.deacon@....com>
Signed-off-by: Michael Weiser <michael.weiser@....de>
Signed-off-by: Will Deacon <will.deacon@....com>
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
This was backported to v4.14 and later, but is missing in v4.4 and
before, apparently because of a trivial merge conflict. This is
a manual backport I did after I saw a report about the issue
by Martin Vajnar on the musl mailing list.
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
arch/arm64/kernel/traps.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c
index 9322be69ca09..db4163808c76 100644
--- a/arch/arm64/kernel/traps.c
+++ b/arch/arm64/kernel/traps.c
@@ -363,14 +363,6 @@ asmlinkage long do_ni_syscall(struct pt_regs *regs)
}
#endif
- if (show_unhandled_signals && printk_ratelimit()) {
- pr_info("%s[%d]: syscall %d\n", current->comm,
- task_pid_nr(current), (int)regs->syscallno);
- dump_instr("", regs);
- if (user_mode(regs))
- __show_regs(regs);
- }
-
return sys_ni_syscall();
}
--
2.29.2
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
