Date: Mon, 15 Mar 2021 22:13:25 -0400 From: Rich Felker <dalias@...c.org> To: Alexander Monakov <amonakov@...ras.ru> Cc: musl@...ts.openwall.com, Dominic Chen <d.c.ddcc@...il.com> Subject: Re: Issue with fread() and unaligned readv() On Tue, Mar 16, 2021 at 01:42:48AM +0300, Alexander Monakov wrote: > On Mon, 15 Mar 2021, Rich Felker wrote: > > > > If musl always does such off-by-one, it is an efficiency issue (forces > > > a copy with mismatching source/dest alignment). > > > > It's necessary to work around a kernel bug, whereby the kernel fails > > to honor the requirement that a readv of total length n behave > > identically, except for where the data is stored, as a single read of > > length n. For vfs backends that don't implement a proper readv > > operation, the kernel executes readv as a sequence of reads. When this > > happens, if the amount of data to read is exactly the length of the > > first iov (the length requested by the application), continuing to the > > second iov with no more data available will cause the operation to > > block indefinitely until more data is available. By reducing the > > length of the first iov (the caller's buffer) by 1, we ensure that at > > least 1 byte of the second iov (the FILE's buffer) is actually needed > > to satisfy the caller, and thus that the call will return without > > blocking as soon as everything the caller requested is available. > > Thanks. Can musl reduce the first iov tuple by, say, 8 bytes rather than > 1 byte, to avoid forcing the kernel to perform a misaligned copy? Well then you have to do more copy in userspace afterwards, and reduce the effective buffer size by a bit, going back to kernel slightly more often or spending extra memory to compensate. There's also no strong reason to believe one will be aligned and the other won't, except at beginning of file. The alignment mod 8 depends on file position and access history, and neither the caller's buffer nor the FILE buffer have any inherent alignment. Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.