Date: Wed, 16 Sep 2020 08:04:39 -0400 From: Rich Felker <dalias@...c.org> To: musl@...ts.openwall.com Subject: Re: Bug in mmap_fixed() On Wed, Sep 16, 2020 at 12:15:23AM -0500, Rob Landley wrote: > On 9/5/20 1:44 AM, Markus Wichmann wrote: > > On Fri, Sep 04, 2020 at 11:41:54PM -0400, Rich Felker wrote: > >> When I saw your report, I thought this code all ran with signals > >> blocked, and actually had to check to see that this isn't the case. > > > > In that case, making an exception for EINTR would be even weirder. > > > >> The code hsould be fixed, and EINTR handling should probably be left > >> in-place, just without the wrong pointer-advance logic. > >> > > > > See attached. Untested, obviously, since I lack a Super-H processor and > > an NFS server, > > Coldfire is also nommu and musl has had m68k support for years, is there no > coldfire target? (That's been supported by qemu longer than proper m68k.) > > Rob > > P.S. This patches out the broken fork() on nommu sh2, and fixes the sh2 native > toolchain build: > > https://github.com/landley/toybox/blob/master/scripts/mcm-buildall.sh#L130 You have been told again and again this is not a bug, and your patch is ABI breakage. There is no "nommu version of musl". There is a common ABI that runs on mmuful and nommu machines and whether fork can succeed or not is a runtime property. Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.