Date: Wed, 11 Jul 2018 13:00:34 -0400 From: Rich Felker <dalias@...c.org> To: musl@...ts.openwall.com Subject: Re: getaddrinfo(3) / AI_ADDRCONFIG On Wed, Jul 11, 2018 at 12:50:53PM -0400, Christopher Friedt wrote: > On Wed, Jul 11, 2018, 12:44 PM Rich Felker, <dalias@...c.org> wrote: > > > On Wed, Jul 11, 2018 at 06:12:31AM -0400, Christopher Friedt wrote: > > > On Tue, Jul 10, 2018 at 9:26 PM Rich Felker <dalias@...c.org> wrote: > > > > Pulling in large amounts of additional code and O(n) runtime cost > > > > > > Latest patch  addresses > > > > > > 1) not ignoring loopback > > > 2) using routability of udp packets vs O(n) lookup on network interfaces > > > > > > Any other concerns, Rich? > > > > You seem to have deleted the original patch and replaced it with a new > > > > > Some lists prefer patches to be inline. I wasn't sure if you wanted the > attachment. That clarifies that. > > With that said, it still makes sprawling changes and intraduces a > > gratuitous new file with external interface for something that > > fundamentally takes only a few lines in one place and no external > > interface at all. Formatting is also > > > I'll put it directly inside of getaddrinfo. It could probably go inside __lookup_name, but maybe in getaddrinfo is better since that would avoid linking it for gethostbyname, etc. (which don't need it). > inconsistent with musl (spaces > > after opening and before closing paren, etc.). > > > Ok, will reformat. > > And addition of the > > nonstandard EAI_NODATA is an independent change that, if it makes > > sense at all, needs to be discussed > > > Right. What error would you prefer? I think the one mandated by POSIX is EAI_NONAME ("The name does not resolve for the supplied parameters"). Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.