Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 23 Jun 2020 13:16:28 +0300
From: Alexander Popov <alex.popov@...ux.com>
To: Will Deacon <will@...nel.org>, Kees Cook <keescook@...omium.org>
Cc: Emese Revfy <re.emese@...il.com>,
 Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
 Masahiro Yamada <masahiroy@...nel.org>,
 Michal Marek <michal.lkml@...kovi.net>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Masahiro Yamada <yamada.masahiro@...ionext.com>,
 Thiago Jung Bauermann <bauerman@...ux.ibm.com>,
 Luis Chamberlain <mcgrof@...nel.org>, Jessica Yu <jeyu@...nel.org>,
 Sven Schnelle <svens@...ckframe.org>, Iurii Zaikin <yzaikin@...gle.com>,
 Catalin Marinas <catalin.marinas@....com>,
 Vincenzo Frascino <vincenzo.frascino@....com>,
 Thomas Gleixner <tglx@...utronix.de>, Peter Collingbourne <pcc@...gle.com>,
 Naohiro Aota <naohiro.aota@....com>, Alexander Monakov <amonakov@...ras.ru>,
 Mathias Krause <minipli@...glemail.com>, PaX Team <pageexec@...email.hu>,
 Brad Spengler <spender@...ecurity.net>, Laura Abbott <labbott@...hat.com>,
 Florian Weimer <fweimer@...hat.com>, kernel-hardening@...ts.openwall.com,
 linux-kbuild@...r.kernel.org, x86@...nel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 gcc@....gnu.org, notify@...nel.org
Subject: Re: [PATCH 5/5] gcc-plugins/stackleak: Don't instrument
 vgettimeofday.c in arm64 VDSO

On 10.06.2020 10:30, Will Deacon wrote:
> On Tue, Jun 09, 2020 at 12:09:27PM -0700, Kees Cook wrote:
>> arm_ssp_per_task_plugin.c
>> 	32-bit ARM only (but likely needs disabling for 32-bit ARM vDSO?)

I tested: on 32-bit arm vDSO is built with plugin flags. I will filter them out
in a separate patch in v2 of the series.

> On arm64, the 32-bit toolchain is picked up via CC_COMPAT -- does that still
> get the plugins?
I tested it with this command:
  make  ARCH=arm64 CROSS_COMPILE_COMPAT=arm-linux-gnueabi-
CROSS_COMPILE=aarch64-linux-gnu- V=1

I see that COMPAT_VDSO is built without plugin flags. So it's ok.

Best regards,
Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.