Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 5 Feb 2019 17:54:56 +0000
From: Nadav Amit <>
To: Borislav Petkov <>
CC: Peter Zijlstra <>, Rick Edgecombe
	<>, Andy Lutomirski <>, Ingo Molnar
	<>, LKML <>, X86 ML
	<>, "H. Peter Anvin" <>, Thomas Gleixner
	<>, Dave Hansen <>, Damian
 Tometzki <>, linux-integrity
	<>, LSM List
	<>, Andrew Morton
	<>, Kernel Hardening
	<>, Linux-MM <>, Will
 Deacon <>, Ard Biesheuvel <>,
	Kristen Carlson Accardi <>, "Dock, Deneen T"
	<>, Kees Cook <>, Dave Hansen
	<>, Masami Hiramatsu <>
Subject: Re: [PATCH v2 06/20] x86/alternative: use temporary mm for text

> On Feb 5, 2019, at 4:35 AM, Borislav Petkov <> wrote:
> On Tue, Feb 05, 2019 at 12:31:46PM +0100, Peter Zijlstra wrote:
>> ...
>> So while in general I agree with BUG_ON() being undesirable, I think
>> liberal sprinking in text_poke() is fine; you really _REALLY_ want this
>> to work or fail loudly. Text corruption is just painful.
> Ok. It would be good to have the gist of this sentiment in a comment
> above it so that it is absolutely clear why we're doing it.

I added a short comment for v3 above each BUG_ON().

> And since text_poke() can't fail, then it doesn't need a retval too.
> AFAICT, nothing is actually using it.

As Peter said, this is addressed in a separate patch (one patch per logical

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.