Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 5 Feb 2019 14:29:53 +0100
From: Peter Zijlstra <>
To: Borislav Petkov <>
Cc: Rick Edgecombe <>,
	Andy Lutomirski <>, Ingo Molnar <>,,,,
	Thomas Gleixner <>,
	Nadav Amit <>,
	Dave Hansen <>,,,,,,,,,,,
	Nadav Amit <>, Kees Cook <>,
	Dave Hansen <>,
	Masami Hiramatsu <>
Subject: Re: [PATCH v2 06/20] x86/alternative: use temporary mm for text

On Tue, Feb 05, 2019 at 12:31:46PM +0100, Peter Zijlstra wrote:
> In general, text_poke() cannot fail:
>  - suppose changing a single jump label requires poking multiple sites
>    (not uncommon), we fail halfway through and then have to undo the
>    first pokes, but those pokes fail again.
>  - this then leaves us no way forward and no way back, we've got
>    inconsistent text state -> FAIL.

Note that this exact fail scenario still exists in the CPU hotplug code.
See kernel/cpu.c:cpuhp_thread_fun():

		 * If we fail on a rollback, we're up a creek without no
		 * paddle, no way forward, no way back. We loose, thanks for
		 * playing.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.