Date: Thu, 15 Mar 2018 22:27:11 +0100 (CET) From: Thomas Gleixner <tglx@...utronix.de> To: Kees Cook <keescook@...omium.org> cc: linux-kernel@...r.kernel.org, Segher Boessenkool <segher@...nel.crashing.org>, kernel-hardening@...ts.openwall.com Subject: Re: [PATCH] rslib: Remove VLAs by setting upper bound on nroots On Sat, 10 Mar 2018, Kees Cook wrote: > Avoid stack VLAs by always allocating the upper bound of stack space > needed. The existing users of rslib appear to max out at 24 roots, > so use that as the upper bound until we have a reason to change it. > > Alternative considered: make init_rs() a true caller-instance and > pre-allocate the workspaces. This would possibly need locking and > a refactoring of the returned structure. > > Using kmalloc in this path doesn't look great, especially since at > least one caller (pstore) is sensitive to allocations during rslib > usage (it expects to run it during an Oops, for example). > >  https://lkml.org/lkml/2018/3/7/621 >  https://lkml.org/lkml/2018/3/9/838 > > Signed-off-by: Kees Cook <keescook@...omium.org> Reviewed-by: Thomas Gleixner <tglx@...utronix.de>
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.