Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 21 Feb 2018 19:20:09 +0900
From: Masahiro Yamada <>
To: Arnd Bergmann <>
Cc: Ulf Magnusson <>, Rich Felker <>,
        Linux-sh list <>,
        Kernel Hardening <>,
        Paul Mackerras <>, "H. Peter Anvin" <>,
        sparclinux <>,
        Sam Ravnborg <>,
        uml-devel <>,
        Yoshinori Sato <>,
        Jonathan Corbet <>, X86 ML <>,
        Linus Torvalds <>,
        Ingo Molnar <>, Emese Revfy <>,
        Kees Cook <>,
        Linux Kbuild mailing list <>,
        Peter Oberparleiter <>,
        Jeff Dike <>,,
        Thomas Gleixner <>,
        Michal Marek <>,
        Greg Kroah-Hartman <>,
        Randy Dunlap <>,
        "open list:DOCUMENTATION" <>,
        Linux Kernel Mailing List <>,
        Richard Weinberger <>,
        linuxppc-dev <>,
        "David S. Miller" <>
Subject: Re: [PATCH 00/23] kconfig: move compiler capability tests to Kconfig

2018-02-21 18:56 GMT+09:00 Arnd Bergmann <>:
> On Wed, Feb 21, 2018 at 8:38 AM, Masahiro Yamada
> <> wrote:
>> 2018-02-20 0:18 GMT+09:00 Ulf Magnusson <>:
>>>> I'm not happy that we in one context can reference CONFIG variables
>>>> directly, but inside the $(call ...) and $(shell ...) needs the $ prefix.
>>>> But I could not come up with something un-ambigious where this could be avoided.
>>> I think we should be careful about allowing references to config
>>> symbols. It mixes up the parsing and evaluation phases, since $() is
>>> expanded during parsing (which I consider a feature and think is
>>> needed to retain sanity).
>>> Patch 06/23 removes the last existing instance of symbol references in
>>> strings by getting rid of 'option env'. That's an improvement to me.
>>> We shouldn't add it back.
>> This is really important design decision,
>> so I'd like to hear a little more from experts.
>> For example, x86 allows users to choose sub-arch, either 'i386' or 'x86_64'.
>> If the user toggles CONFIG_64BIT,
>> the bi-arch compiler will work in a slightly different mode
>> (at least, back-end parts)
>> So, my question is, is there a case,
>> $(cc-option, -m32 -foo) is y, but
>> $(cc-option, -m64 -foo) is n  ?
>> (or vice versa)
>> If the answer is yes, $(cc-option -foo) would have to be re-calculated
>> every time CONFIG_64BIT is toggled.
>> This is what I'd like to avoid, though.
> The -m32/-m64 trick (and -mbig-endian/-mlittle-endian on other architectures
> as well as a couple of other flags) only works if the compiler is configured to
> support it. In other cases (e.g. big-endian xtensa), the kernel always
> detects what the compiler does and silently configures itself to match
> using Makefile logic.
> On x86, compilers are usually built as bi-arch, but you can build one that
> only allows one of them.
> I can see two reasonable ways out:
> - we don't use  $(cc-option -foo) in a case like this, and instead require the
>   user to have a matching toolchain.
> - we could make the 32/64 selection on x86 a 'choice' statement where
>   each option depends on both the ARCH= variable and the
>   $(cc-option, -m32)/ $(cc-option, -m64) output.
>        Arnd

Let me clarify my concern.

When we test the compiler flag, is there a case
where a particular flag depends on -m{32,64} ?

For example, is there a compiler that supports -fstack-protector
for 64bit mode, but unsupports it for 32bit mode?

  $(cc-option -m32)                     ->  y
  $(cc-option -m64)                     ->  y
  $(cc-option -fstack-protector)        ->  y
  $(cc-option -m32 -fstack-protector)   ->  n
  $(cc-option -m64 -fstack-protector)   ->  y

I guess this is unlikely to happen,
but I am not whether it is zero possibility.

If this could happen,
$(cc-option ) must be evaluated together with
correct bi-arch option (either -m32 or -m64).

Currently, -m32/-m64 is specified in Makefile,
but we are moving compiler tests to Kconfig
and, CONFIG_64BIT can be dynamically toggled in Kconfig.

Best Regards
Masahiro Yamada

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.