Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 29 Nov 2017 10:07:27 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Linus Torvalds' <>, "Tobin C. Harding"
CC: ""
	<>, "Jason A. Donenfeld"
	<>, Theodore Ts'o <>, Kees Cook
	<>, Paolo Bonzini <>, Tycho Andersen
	<>, "Roberts, William C" <>, "Tejun
 Heo" <>, Jordan Glover <>, Greg KH
	<>, Petr Mladek <>, Joe Perches
	<>, Ian Campbell <>, Sergey Senozhatsky
	<>, Catalin Marinas <>,
	Will Deacon <>, Steven Rostedt <>,
	Chris Fries <>, Dave Weinstein <>, "Daniel
 Micay" <>, Djalal Harouni <>,
	Radim Krcm√°r <>, "Linux Kernel Mailing
 List" <>, Network Development
	<>, David Miller <>, "Stephen
 Rothwell" <>, Andrey Ryabinin <>,
	Alexander Potapenko <>, Dmitry Vyukov <>,
	Andrew Morton <>
Subject: RE: [PATCH V11 4/5] vsprintf: add printk specifier %px

From: Linus Torvalds
> Sent: 29 November 2017 02:29
> On Tue, Nov 28, 2017 at 6:05 PM, Tobin C. Harding <> wrote:
> >
> >    Let's add specifier %px as a
> > clear, opt-in, way to print a pointer and maintain some level of
> > isolation from all the other hex integer output within the Kernel.
> Yes, I like this model. It's easy and it's obvious ("'x' for hex"),
> and it gives people a good way to say "yes, I really want the actual
> address as hex" for if/when the hashed pointer doesn't work for some
> reason.

Remind me to change every %p to %px on kernels that support it.

Although the absolute values of pointers may not be useful, knowing
that two pointer differ by a small amount is useful.
It is also useful to know whether pointers are to stack, code, static
data or heap.

This change to %p is going to make debugging a nightmare.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.