Date: Thu, 29 Jun 2017 09:11:10 -0700 From: Kees Cook <keescook@...omium.org> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Daniel Borkmann <daniel@...earbox.net>, Michael Ellerman <mpe@...erman.id.au>, "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>, LKML <linux-kernel@...r.kernel.org>, Laura Abbott <labbott@...hat.com> Subject: Re: [RFC PATCH 1/4] Provide linux/set_memory.h On Thu, Jun 29, 2017 at 2:03 AM, Daniel Borkmann <daniel@...earbox.net> wrote: > On 06/29/2017 08:29 AM, Michael Ellerman wrote: >> >> Currently code that wants to use set_memory_ro() etc, needs to include >> asm/set_memory.h, which doesn't exist on all arches. Some code knows >> it only builds on arches which have the header, other code guards the >> inclusion with an #ifdef, neither is ideal. >> >> So create linux/set_memory.h. This always exists, so users don't need >> an #ifdef just to include the header. >> >> When CONFIG_ARCH_HAS_SET_MEMORY=y it includes asm/set_memory.h, >> otherwise it provides empty non-failing implementations. >> >> Signed-off-by: Michael Ellerman <mpe@...erman.id.au> > > > Looks good to me, thanks! > > Acked-by: Daniel Borkmann <daniel@...earbox.net> > > I'm fine if Andrew or Kees picks up the bpf patch as well, I think > there shouldn't be any conflict with net-next on this one (and even > if so, then looks trivial to resolve). I nominate Andrew. ;) This should go in early in the merge window and the users can go late in the window. If Andrew has enough to do, I can carry it too; just say the word. This is a sane addition and allows for lines-of-code reduction in a few places. Thanks! Acked-by: Kees Cook <keescook@...omium.org> -Kees -- Kees Cook Pixel Security
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.