Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 28 May 2017 09:55:37 -0700
From: Kees Cook <>
To: Christoph Hellwig <>
Cc: "" <>, Laura Abbott <>, 
	"" <>, LKML <>
Subject: Re: [PATCH v2 01/20] NFS: Avoid cross-structure casting

On Sun, May 28, 2017 at 12:53 AM, Christoph Hellwig <> wrote:
> On Fri, May 26, 2017 at 01:17:05PM -0700, Kees Cook wrote:
>> When the call to nfs_devname() fails, the error path attempts to retain
>> the error via the mnt variable, but this requires a cast across very
>> different types (char * to struct vfsmount *), which the upcoming
>> structure layout randomization plugin flags as being potentially
>> dangerous in the face of randomization. This is a false positive, but
>> what this code actually wants to do is retain the error value, so this
>> patch explicitly sets it, instead of using what seems to be an
>> unexpected cast.
>> Signed-off-by: Kees Cook <>
>> Acked-by: Trond Myklebust <>
> Looks good:
> Reviewed-by: Christoph Hellwig <>
> And I think we should get this (and the other cast patches) in ASAP,
> independent of the fat of the randstruct plugin.

Should I send a pull request to Linus for these for v4.12?


Kees Cook
Pixel Security

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.