Date: Sun, 28 May 2017 01:15:41 -0700 From: Christoph Hellwig <hch@...radead.org> To: Kees Cook <keescook@...omium.org> Cc: kernel-hardening@...ts.openwall.com, "David S . Miller" <davem@...emloft.net>, Laura Abbott <labbott@...hat.com>, x86@...nel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 08/20] randstruct: Whitelist NIU struct page overloading On Fri, May 26, 2017 at 01:17:12PM -0700, Kees Cook wrote: > The NIU ethernet driver intentionally stores a page struct pointer on > top of the "mapping" field. Whitelist this case: > > drivers/net/ethernet/sun/niu.c: In function ‘niu_rx_pkt_ignore’: > drivers/net/ethernet/sun/niu.c:3402:10: note: found mismatched ssa struct pointer types: ‘struct page’ and ‘struct address_space’ > > *link = (struct page *) page->mapping; > ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Cc: David S. Miller <davem@...emloft.net> > Signed-off-by: Kees Cook <keescook@...omium.org> The driver really needs to stop doing this anyway. It would be good to send this out to linux-mm and netdev to come up with a better scheme.
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.