Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 12 Dec 2016 12:45:18 -0600
From: Gary R Hook <>
To: Andy Lutomirski <>, Eric Biggers <>
CC: <>, ""
	<>, "" <>,
	"" <>,
	Herbert Xu <>, Andrew Lutomirski
	<>, Stephan Mueller <>
Subject: Re: Remaining crypto API regressions with CONFIG_VMAP_STACK

On 12/12/2016 12:34 PM, Andy Lutomirski wrote:


> I have a patch to make these depend on !VMAP_STACK.
>>         drivers/crypto/ccp/ccp-crypto-aes-cmac.c:105,119,142
>>         drivers/crypto/ccp/ccp-crypto-sha.c:95,109,124
>>         drivers/crypto/ccp/ccp-crypto-aes-xts.c:162
>>         drivers/crypto/ccp/ccp-crypto-aes.c:94
> According to Herbert, these are fine.  I'm personally less convinced
> since I'm very confused as to what "async" means in the crypto code,
> but I'm going to leave these alone.

I went back through the code, and AFAICT every argument to sg_init_one() in
the above-cited files is a buffer that is part of the request context. Which
is allocated by the crypto framework, and therefore will never be on the 

I don't (as yet) see a need for any patch to these. Someone correct me 
if I'm
missing something.


This is my day job. Follow me at:
IG/Twitter/Facebook: @grhookphoto
IG/Twitter/Facebook: @grhphotographer

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.