Date: Fri, 6 May 2011 20:07:30 -0700 From: Dhiru Kholia <dhiru.kholia@...il.com> To: john-users@...ts.openwall.com Subject: Re: Plumbing changes On Fri, May 6, 2011 at 6:27 PM, magnum <rawsmooth@...dband.net> wrote: > I think if we come to the point where it's just one line in Makefile and two > in john.c, we should get along just fine as-is [for new formats] as long as > people choose good points of inserting new lines. For example, Dhiru's three > patches all add their lines in the exact same spot (no offense, just > sayin'). If he had put the SybaseASE line very high in the list (as it was > the first patch since Jumbo), the ssh line at least four lines down from > that, and the rar line four lines down again, the pathes would not clash. > > If he had done it that way, and I wrote a new format, I'd just put my lines > four lines below the rar line. The only thing needed is having a look at the > formats already posted but not included in Jumbo. I agree :-). All my patches are independent of each other and are built to apply on top of jumbo patchset. (I like to start with a clean slate for each work since I work in a BFS fashion it seems). heh. Can the new version control thing being discussed on the mailing list solve or blunt this problem? Each patch living on a central server in an independent but frequently merged branches? -- Thanks, Dhiru
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.