Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 16 Jun 2015 17:39:05 +0300
From: Shinnok <>
Subject: Re: [Johnny] Task 1.6.1 Multiple cracking session management

> On Jun 11, 2015, at 11:28 PM, Mathieu Laprise <> wrote:
> Shinnok said :
> What we need is a wrapper class named JohnSession that encompasses all settings that define a cracking session. All values are still stored and loaded via QSettings inside the class.
> What variables do you have in mind for JohnSession ? In my mind right now, I don't see what we'll put into it because with m_setting(QSetting) in MainWindow class, we will have all our information into the SAME member variable. 
> For example, the groups will make something like this :
> m_setting.getValue(session/nameOfSession1/isForkEnabled); m_setting.getValue(session/nameOfSession2/isForkEnabled);
> m_Setting.getValue(session/nameOfSession1/mode); 
> etc..

Encapsulating those calls in a JohnSession has multiple reasons:

1. We get rid of ugly getValue() / setValue() calls spread all over the UI code;
2. We start defining what an attack session is; (A name, a set of input files, JohnSession.mode(), JohnSession.isForkEnabled(), etc.. you get the idea)
3. We can pass a fully defined session around as a single variable;
4. We get to write more beautiful code, for e.g. by doing JohnSession.load() instead of iterating over lists and other data types and serializing/deserializing each and every option in the UI code.

I see you have quite some progress on PR #24. Before I can proceed to the review, can you please writeup a small summary here of what have you accomplished so far with it? It will make my job a bit easier.

Content of type "text/html" skipped

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.