Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 10 Apr 2013 18:56:58 +0200
From: magnum <>
Subject: Re: default_cmp_all

So the new-style bitmaps fully replace cmp_all()? I thought they only replace it under certain conditions. I suggest we do absolutely nothing until Solar comments this.


On 10 Apr, 2013, at 14:50 , <> wrote:

> It looks like there is not fmt_default_cmp_all, but there probably should be.  There can often be a decent amount of coding time placed into that function, and for naught, if the format is non-salted.  Yes, the function IS used, on non-salted, and must return 1, simply to pass self tests, but a stub function simply returning 1 would be just as valid as a complex function.
> There could even be checks put into self-test to warn that a non-default cmp_all is being used in a non-salted format, and error out if default IS being used in a salted format.
> Something to look at in bleeding.
> ---- wrote: 
>> However, digging deeper into JtR's actual running, I found out something I did not know before.  cmp_all is ONLY called for salted types.  I thought cmp_all was always called.  The cmp_all does get called, always, within the self test code, but the expectation there, is that cmp_all should return true, which this version does.
>> Magnum, I wonder if self-test code should mirror this logic (not calling cmp_all for non-salted), or if possibly all non-salted formats should have their cmp_all functions removed, and replaced with fmt_default_cmp_all  ?

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.