Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 10 Apr 2013 13:55:09 -0500
From: "jfoug" <>
To: <>
Subject: RE: default_cmp_all

From: magnum [] 
>So the new-style bitmaps fully replace cmp_all()? I thought they only
replace it under certain conditions. I >suggest we do absolutely nothing
until Solar comments this.

I agree with the wait and see.  However, cmp_all is not called in the
current unstable either (prior to the bitmaps).  Look at the code in

There is an outer if statement, on whether the format is salted or not. If
not salted, then the else route is taken, and within that block of code,
cmp_all is never called, and only the bin_hashes and cmp_one/cmp_exact is
used.  I am not fully sold that is the right way, BUT that is how JtR has
been running forever (for a long time at least).

Like I said, it was news to me, and surprised me some.  I thought the code
always something similar to:

if (hash() && cmp_all()) {
   foreach: if (cmp_one() && cmp_exact())
     output found pw

But it is not that way for non-salted.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.