Date: Mon, 20 Aug 2012 15:28:36 -0500 From: Jeffrey Goldberg <jeffrey@...dmark.org> To: john-dev@...ts.openwall.com Subject: Re: OSX 10.8 (GT 650M) build fail On 2012-08-18, at 8:29 PM, magnum <john.magnum@...hmail.com> wrote: >> LC_ALL=C sed ... >> >> (which I guess is what you implemented now), and see if this works. > > That is what I did now, but I still don't get why my previous try did > not work. I had it like this: > > SED = sed > NULL = /dev/null > CPPFLAGS = -E > + LC_ALL = C > > That may have downsides but I'm puzzled why it did not work. Setting FOO = bar in a Makefile only sets a "Make variable". It doesn't get set in the environment in which the commands are executed. On the whole, I think that OS X is mistaken to not set LC_ALL in /etc/bash_profile and /etc/csh.login. I've had the problem with more than john, so I've set LC_ALL=C in ~/.profile and ~/.cshrc Without building a Makefile from a configure script, I think the best solution is the add instructions to a README file for OS X users to set LC_ALL in their environment. On the other hand, It actually make some sense to have LC_ALL=C sed ... in the Makefile. After all, we don't want the result of the sed to depend on whether people are using Korean or Magyar collation rules. Cheers, -j
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.