[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 20 Aug 2012 23:41:22 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: OSX 10.8 (GT 650M) build fail
On 2012-08-20 22:28, Jeffrey Goldberg wrote:
> On 2012-08-18, at 8:29 PM, magnum <john.magnum@...hmail.com> wrote:
>> I had it like this:
>>
>> SED = sed
>> NULL = /dev/null
>> CPPFLAGS = -E
>> + LC_ALL = C
>>
>> That may have downsides but I'm puzzled why it did not work.
>
> Setting
>
> FOO = bar
>
> in a Makefile only sets a "Make variable". It doesn't get set in the
> environment in which the commands are executed.
I was confused by this: "Variables in make can come from the environment
in which make is run. Every environment variable that make sees when it
starts up is transformed into a make variable with the same name and
value. However, an explicit assignment in the makefile, or with a
command argument, overrides the environment."
http://www.gnu.org/software/make/manual/html_node/Environment.html
I assumed that make variables also flow to child environments - but this
is evidently not the case.
> Without building a Makefile from a configure script, I think the best
> solution is the add instructions to a README file for OS X users to
> set LC_ALL in their environment.
>
> On the other hand, It actually make some sense to have
>
> LC_ALL=C sed ...
>
> in the Makefile. After all, we don't want the result of the sed to
> depend on whether people are using Korean or Magyar collation rules.
I think the current solution should be safe - we use "LC_ALL=C sed ..."
but only where actually needed.
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
