Date: Mon, 23 Jul 2012 19:32:21 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: Some more external mode definitions On 2012-07-23 18:10, Frank Dittrich wrote: > On 07/23/2012 05:11 PM, magnum wrote: >> On 2012-07-23 15:14, Frank Dittrich wrote: >>> Since I prefer not to push changes into your repository without a chance >>> for others to review them, I'll include the patch inlined at the end of >>> my mail. >> >> You wont push directly anyway. When you send a pull request, the one >> accepting it (usually me or Dhiru) can/should review it. Having said >> that, it's not a bad idea to show it here too. > > I know I don't push into your repository. and this was a trivial change > anyway. But generally, I'd prefer comments and suggestions prior to > changes being published in your repository and pulled by others. > May be I shouldn't care about that. For core changes like this, I agree. > I just sent a pull request for this change + (in a separate commit) the > filter_rot13 rewritten for easier adjustment (rot1 ... rot25?) Excellent! magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.