Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 25 Jun 2012 21:44:32 +0200
From: Frank Dittrich <>
Subject: Markov: move mkv_start / mkv_end computation out of do_markov_crack()
 (was: committed patches)

On 06/25/2012 08:46 PM, magnum wrote:
> Committed now. Meld is a frigging excellent tool, I did not even get the
> merging problems I feared in the contest tree.

Because you are a brave man, I have a new patch for you.

This one doesn't introduce any new logic, I was just refactoring
existing code.
Now the mkv_start and mkv_end computation is moved out of
do_markov_crack() and into a new function get_markov_start_end().

Just the MPI specific mkv_start / mkv_end adjustment remains in

I compiled each intermediate transformation step, and verified that
these commands all behaved like they did before my refactoring:

$ ./john --stdout --markov:200:1%:2%:12 |head -n 1
$ ./john --stdout --markov:200:1%:2%:12 |tail -n 1
$ ./john --stdout --markov:200:2593564:5187128:12 |head -n 1
$ ./john --stdout --markov:200:2593564:5187128:12 |tail -n 1

> I did not drop the docs, we can just as well have it documented. I bet
> more people will use this than MPI anyway (doh!).

May be it is better documented or easier to use than MPI is?


View attachment "0001-Markov-move-mkv_start-mkv_end-computation-out-of-do_.patch" of type "text/x-patch" (6254 bytes)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.