Date: Tue, 17 Jan 2012 23:24:24 +0100 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: Recent CVS patches On 01/17/2012 06:43 PM, magnum wrote: > On 01/17/2012 04:14 PM, magnum wrote: > I'm only 99% sure what is happening but the enclosed patch removes 267 > complaint contexts from Valgrind in Jumbo (but these problems did not > result in any test fails). There are still a couple of problems > (actually 14, including trip as described below) but these I think are > actual bugs in the formats and false positives. I feel more confident now, this is definately a correct fix and it's only an issue for Jumbo. The array index was an unnecessary complicated way to say 0 though, this is the final line I'll be using: if (salts == 1) format->methods.set_salt(two_salts); > I suppose this is due to some formats just copying the pointer in > set_salt() (in core John, this is not an issue afaik) and it still > points to the now freed salt_copy from previous alignment tests. This is precisely the reason. magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.