Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 31 Oct 2011 02:52:15 +0400
From: Solar Designer <solar@...nwall.com>
To: owl-dev@...ts.openwall.com
Subject: Re: syslinux

On Mon, Oct 31, 2011 at 12:03:02AM +0400, Vasiliy Kulikov wrote:
> A dummy thing - isolinux doesn't see a file with "-" inside.  I'll commit
> the fix after the full install testing tomorrow.

I would have appreciated you posting the fix in here.  It is wrong for
us to keep the publicly available Owl-current tree in a broken state for
longer than necessary.  Even an untested fix is better than no fix at all.

I tried to find that issue with '-' in the code myself, but failed (in
the time I spent so far).  However, I found that there's some support
for symlinks.  syslinux-4.04/core/fs/fs.c has:

/* Symlink hard limits */
#define MAX_SYMLINK_CNT 20
#define MAX_SYMLINK_BUF 4096

and these are used in searchdir().  Yet you said symlinks didn't work?
They certainly produce a different kind of error for me, as I mentioned,
so there's probably in fact something wrong with them.

Is this not the right place in the code to look at?  Or is something
else involved (such as to actually read the kernel image), where support
for symlinks is missing and an issue with '-' exists?

searchdir() is invoked from ui.inc via:

                pm_call pm_searchdir

So I think it is relevant, but perhaps something else is as well.

Thanks,

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.