Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 29 Oct 2011 13:49:13 +0400
From: Vasiliy Kulikov <segoon@...nwall.com>
To: owl-dev@...ts.openwall.com
Subject: Re: syslinux

Solar,

On Fri, Oct 28, 2011 at 15:00 +0400, Solar Designer wrote:
> > -log "Installing sources"
> ...
> > +if [ "$COPY_SOURCES" != "NO" ]; then
> 
> These extra changes should be committed separately from (before or
> after) the move from LILO to ISOLINUX.  Also, how about we use more
> consistent shell variable names - e.g., ISO_COMPRESS instead of
> COMPRESS_ISO, and then also ISO_COPY_SOURCES?

OK.

> I understand that you did not want to duplicate the lengthy list of
> options to mkisofs, but creating an uncompressed .iso file on disk
> unnecessarily is not good.  I suggest that you do something like:
> 
> MKISOFS_OPTS='...'
> if [ -z "$COMPRESS_ISO" ]; then
> 	mkisofs $MKISOFS_OPTS "$ROOT" | gzip -9 > "$ISO.gz"
> else
> 	mkisofs $MKISOFS_OPTS -o "$ISO" "$ROOT"
> fi

OK.

> Also, it'd be nice to start including the arch name in default ISO and
> vztemplate filenames (should be a separate commit, though).  I already
> do such renames of files that we release - manually.

What is the best way to get the arch?  Given we'll probably support
multiarch in the future.

> > The isolinux.cfg:
> > 
> >     timeout 50
> >     display /boot/message
> >     default normal
> >     prompt 1
> 
> Does our current message (explaining "safe" and "rescue") display OK?

I'm playing with "menu" commands, I'll answer it a bit later.

> >     label rescue
> >     kernel /boot/vmlinuz
> 
> With "safe" and "rescue", do the existing instructions apply? -

Yes.


> Is there possibly a feature in ISOLINUX to prevent the rescue label from
> being booted without a root device specified?  Right now, with LILO, a
> common user error is to just try booting "rescue", which then fails with
> a kernel panic.

I don't see such an option.  If the kernel image is bogus, syslinux fails to
continue and keeps the user in the menu.  But I cannot see how to
force "root=" passing...

Thanks,

-- 
Vasiliy

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.