owl-dev - iproute2 2.6.38

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110323165514.GA26658@albatros>
Date: Wed, 23 Mar 2011 19:55:14 +0300
From: Vasiliy Kulikov <segoon@...nwall.com>
To: owl-dev@...ts.openwall.com
Subject: iproute2 2.6.38

Solar, all -

I'm updating iproute2 to 2.6.38 and picking some patches from ALT Linux.

http://sisyphus.ru/ru/srpm/Sisyphus/iproute2/patches

Patches I want to include:

iproute2-2.4.7-alt-rtacct_daemon.diff
iproute2-2.6.18-alt-ifcfg.diff
iproute2-2.6.18-alt-ip-man.diff
iproute2-2.6.28-alt-format_not_a_string_literal_and_no_format_arguments.diff

I'm not sure about the patch iproute2-2.6.35-fixrouteget.patch:
http://sisyphus.ru/ru/srpm/Sisyphus/iproute2/patches
https://bugzilla.altlinux.org/show_bug.cgi?id=23872

I cannot reproduce the bug with these steps;  also I'm not sure about the
fix itself - filter.cloned is set to 2 in iproute_get() and results of
all boolean expressions are well defined, e.g. !0 == 1 and !!15 == 1, so
maybe authors of the code might want to compare 2 and 0 or 2 and 1.
I didn't try to understand ip's logic, but the patch itself looks
suspicious to me.

The same with iproute2-2.6.25-segfault.patch:
http://sisyphus.ru/ru/srpm/Sisyphus/iproute2/patches/2
https://bugzilla.altlinux.org/show_bug.cgi?id=15409

I cannot reproduce the segfault and IMO the patch makes no sense - it is
a plain copy-paste from strncpy's manpage.

I don't want to include them unless someone is able to reproduce these bugs.

About packetizing new executables:

I don't know what it is, it has no documentation:

    /sbin/genl

These are 2 bash script wrappers of ip:

    /sbin/routef
    /sbin/routel

And I suppose we still don't want to packetize arpd, right?

About documentation:

%doc RELNOTES examples
%doc README.distribution  README.iproute2+tc  README.lnstat

Thanks,

-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.