|
|
Message-ID: <20261120123825.GA11185@openwall.com> Date: Fri, 20 Nov 2026 13:38:25 +0100 From: Solar Designer <solar@...nwall.com> To: Rich Felker <dalias@...c.org> Cc: Lukas Tribus <lukas@...i.eu>, musl@...ts.openwall.com Subject: Re: crypt: unsupported hash behavior On Fri, Nov 20, 2026 at 07:23:14AM -0500, Rich Felker wrote: > On Fri, Nov 20, 2026 at 10:53:00AM +0100, Solar Designer wrote: > > Not addressing the issue of leaving the hash in memory yet, but I assume > > that's intentional not to address in this same patch? > > Yeah I wasn't sure what to best do with that. I thought of having the > loop that computes the sum also xor the setting string onto the > output, which would be a great way to keep a dependency and avoid > short-circuiting the loop, but that leaks setting (good hash) on > failure which is even worse. I guess I could just make the loop > overwrite output as it runs -- that might be worthwhile. I had thought of this too, but the problem is we don't know we need to overwrite output until the loop ends. Also the early exit on strlen(_setting) != 13 must not skip the zeroization. Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.