Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <av33YHWCKvCq_f4q@cloudsdale.lanodan.eu>
Date: Wed, 18 Nov 2026 20:07:12 +0100
From: "Haelwenn (lanodan) Monnier" <contact@...ktivis.me>
To: musl@...ts.openwall.com
Cc: illiliti <ilt@...s.net>
Subject: Re: [PATCH v1 04/18] fts: drop __BEGIN_DECLS, BSD-specific
 headers

[2026-11-18 15:49:46+0300] illiliti:
>---
> include/fts.h | 16 +++++-----------
> 1 file changed, 5 insertions(+), 11 deletions(-)
>
>diff --git a/include/fts.h b/include/fts.h
>index 394948c5..0d3565fa 100644
>--- a/include/fts.h
>+++ b/include/fts.h
>@@ -135,17 +135,11 @@ typedef struct _ftsent {
> 	char fts_name[1];		/* file name */
> } FTSENT;
>
>-#include <sys/cdefs.h>
>-

Shouldn't it retain C++ extern guards like so?

#ifdef __cplusplus
extern "C" {
#endif

>-#ifndef	__LIBC12_SOURCE__
>-FTSENT	*fts_children(FTS *, int)		__RENAME(__fts_children60);
>-int	 fts_close(FTS *)			__RENAME(__fts_close60);
>+FTSENT	*fts_children(FTS *, int);
>+int	 fts_close(FTS *);
> FTS	*fts_open(char * const *, int,
>-    int (*)(const FTSENT **, const FTSENT **))	__RENAME(__fts_open60);
>-FTSENT	*fts_read(FTS *)			__RENAME(__fts_read60);
>-int	 fts_set(FTS *, FTSENT *, int)		__RENAME(__fts_set60);
>-#endif
>-__END_DECLS
>+    int (*)(const FTSENT **, const FTSENT **));
>+FTSENT	*fts_read(FTS *);
>+int	 fts_set(FTS *, FTSENT *, int);

}

>
> #endif /* !_FTS_H_ */
>-- 
>2.55.0

Best regards

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.