[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20260307012444.GL3520958@port70.net>
Date: Sat, 7 Mar 2026 02:24:44 +0100
From: Szabolcs Nagy <nsz@...t70.net>
To: Michael Forney <mforney@...rney.org>, musl@...ts.openwall.com
Subject: Re: [PATCH v2] mallocng: prevent stray ';' at top-level
* Szabolcs Nagy <nsz@...t70.net> [2026-03-07 02:17:40 +0100]:
> * Michael Forney <mforney@...rney.org> [2024-04-15 03:26:17 -0700]:
> > The LOCK_OBJ_DEF macro is used with a trailing semicolon. However,
> > since the macro definition ends with the closing brace of a function
> > definition, the ISO C grammar does not allow an extra semicolon.
> >
> > To fix this, swap the order of the two definitions, and drop the
> > semicolon from the __malloc_lock declaration.
>
> fwiw i'd do the other way around: remove the ; at usage site.
>
> this is supposed to be a macro that can expand to whatever lock
> with whatever syntax at top level scope, the ; adds unnecessary
> syntax constraint.
ive just seen the v1 thread, i guess v2 does not break api.
looks good.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
