[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20251007014036.GJ1827@brightrain.aerifal.cx>
Date: Mon, 6 Oct 2025 21:40:36 -0400
From: Rich Felker <dalias@...c.org>
To: raf <musl@....org>
Cc: musl@...ts.openwall.com
Subject: Re: [PATCH] fnmatch: fix infinite loop when pattern is
non-character byte
On Sat, Oct 04, 2025 at 10:54:13PM +1000, raf wrote:
> Hi,
>
> fnmatch() enters an infinite loop if the pattern is the non-character byte
> '\xf8'. This patch fixes it by stepping over the invalid byte.
This does not sound like a correct fix. The UNMATCHABLE return from
pat_next should produce an immediate FNM_NOMATCH return, not resume
parsing in an invalid location.
For future submissions, could you also please include patch
descriptions in the same email as the patch itself rather than
degenerate 2-mail threads? That helps make it so we can reply to both
the description/motivation and the actual code changes in a single
reply mail without manually copy-pasting from multiple mails and
picking a place to stitch it into the thread.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
