Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.BSM.4.64L.2507111914290.28278@herc.mirbsd.org>
Date: Fri, 11 Jul 2025 19:15:20 +0000 (UTC)
From: Thorsten Glaser <tg@...bsd.de>
To: musl@...ts.openwall.com
Subject: Re: [PATCH 1/4] scandir: hide that errno is set to 0

Luca Kellermann dixit:

>+		if (sel) {
>+			/* sel() must not observe that errno was set to 0. */
>+			errno = old_errno;
>+			if (!sel(de)) continue;
>+		}

Should this not restore errrno to 0 for the next code?

>+			if (!sel(de)) {
>+				errno = 0;
>+				continue;
>+			}
>+			errno = 0;

bye,
//mirabilos
-- 
15:41⎜<Lo-lan-do:#fusionforge> Somebody write a testsuite for helloworld :-)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.