Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250605232907.GG1827@brightrain.aerifal.cx>
Date: Thu, 5 Jun 2025 19:29:07 -0400
From: Rich Felker <dalias@...c.org>
To: Thorsten Glaser <tg@...bsd.de>
Cc: musl@...ts.openwall.com
Subject: Re: Sign conversion warning in FD_ISSET()

On Fri, Jun 06, 2025 at 12:17:19AM +0200, Thorsten Glaser wrote:
> On Thu, 5 Jun 2025, Rich Felker wrote:
> 
> >In general, it looks like -Wsign-conversion is a very badly-behaved
> >warning that's not interacting right with the normal logic to suppress
> >warnings from system headers.
> 
> I thought so at first, too. But this is not code that is contained
> wholly in the system header: the warning thinks the macro must be
> called with an unsigned type, but the user calls it with signed int,
> so it triggers.

But that's what I'm saying they're doing wrong. Warnings from
*anything* in the expansion of the macro should be suppressed. It
should not be trying to infer a correct type and warning for mismatch.

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.