Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 21 Jun 2024 09:47:19 +0200
From: Christian Brauner <>
To: Arnd Bergmann <>
	Arnd Bergmann <>, Thomas Bogendoerfer <>,, Helge Deller <>,, 
	"David S. Miller" <>, Andreas Larsson <>,, Michael Ellerman <>, 
	Nicholas Piggin <>, Christophe Leroy <>, 
	"Naveen N . Rao" <>,, Brian Cain <>,, Guo Ren <>,, 
	Heiko Carstens <>,, Rich Felker <>, 
	John Paul Adrian Glaubitz <>,, "H. Peter Anvin" <>, 
	Alexander Viro <>,,,,,
Subject: Re: [PATCH 01/15] ftruncate: pass a signed offset

On Thu, Jun 20, 2024 at 06:23:02PM GMT, Arnd Bergmann wrote:
> From: Arnd Bergmann <>
> The old ftruncate() syscall, using the 32-bit off_t misses a sign
> extension when called in compat mode on 64-bit architectures.  As a
> result, passing a negative length accidentally succeeds in truncating
> to file size between 2GiB and 4GiB.
> Changing the type of the compat syscall to the signed compat_off_t
> changes the behavior so it instead returns -EINVAL.
> The native entry point, the truncate() syscall and the corresponding
> loff_t based variants are all correct already and do not suffer
> from this mistake.
> Fixes: 3f6d078d4acc ("fix compat truncate/ftruncate")
> Cc:
> Signed-off-by: Arnd Bergmann <>
> ---

Looks good to me,
Reviewed-by: Christian Brauner <>

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.