Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 24 May 2024 17:16:41 -0700
From: Collin Funk <>
To: Rich Felker <>, Leah Neukirchen <>
Subject: Re: getusershell should ignore comments and empty lines.

Hi Rich,

On 5/23/24 8:27 AM, Rich Felker wrote:
>> In general, musl policy is to support at most what's consistent
>> between historical implementations.
>> It seems like they all ignore lines that start with a '#'. They might
>> (not clear from the above) also ignore blank lines.
>> The minimal change both to avoid clashing with vaguely reasonable
>> things user might want to put there (and violating least surprise),
>> and to support the common behavior, seems to be just looping as long
>> as the line is empty or starts with #.
> Something like this?

Thanks for explaining how Musl handles things.

I haven't tested your patch but it looks correct.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.