[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 5 Aug 2023 11:43:08 -0400
From: Rich Felker <dalias@...c.org>
To: 翟小娟 <zhaixiaojuan@...ngson.cn>
Cc: musl@...ts.openwall.com
Subject: Re: Re: add loongarch64 port v7.
On Sat, Aug 05, 2023 at 02:18:35PM +0800, 翟小娟 wrote:
> We are currently working on bringing loongarch support to the alpine
> community. Alpine depends on musl, and Alpine and its users are
> waiting for musl to support loongarch. This patch seems to be a long
> time ago, we hope to know the review status of this patch.
Last time I set out to look at it, I hit that the exact patch I had
previously reviewed and tentatively okayed wasn't stored anywhere
permanent. I realize this has taken quite a while, and now there is a
patch on the list, so this coming week I will go back and review the
diff of that against the previous posted version and mailing list
comments. As long as everything matches up, I expect to commit it.
Thanks for checking back in on this, and sorry it's taken so long.
Rich
> > -----原始邮件-----
> > 发件人: "Hongliang Wang" <wanghongliang@...ngson.cn>
> > 发送时间:2023-07-19 14:55:31 (星期三)
> > 收件人: musl@...ts.openwall.com
> > 主题: Re: [musl] add loongarch64 port v7.
> >
> > Hi Rich,
> >
> > I asked about the current situation of
> > 0001-add-loongarch64-port-v7.patch in mailing list some times,
> > but I haven't received any response from you. We very hope that
> > LoongArch can be supported in musl as soon as possible and used
> > by more people. So we urgently want to know the current review
> > progress of this patch and what else do we need to do?
> >
> > Thank you for your attention, We're looking forward to your
> > early reply.
> >
> > Best wishes,
> > Hongliang Wang
> >
> >
> > 在 2023/6/25 上午11:43, Hongliang Wang 写道:
> > >
> > > Friendly ping.
> > >
> > > 在 2023/6/1 下午8:44, wanghongliang 写道:
> > >> Hi,Rich
> > >>
> > >> Is there anything else that needs to be modified in
> > >> 0001-add-loongarch64-port-v7.patch?
> > >>
> > >> Looking forward to your reply.
> > >>
> > >>
> > >> 在 2023/5/10 上午11:36, 王洪亮 写道:
> > >>> Hi, Rich
> > >>>
> > >>> Is there anything else that needs to be modified in
> > >>> 0001-add-loongarch64-port-v7.patch?
> > >>>
> > >>>
> > >>> 在 2023/4/18 下午7:32, 王洪亮 写道:
> > >>>>
> > >>>> 在 2023/4/18 下午5:38, Szabolcs Nagy 写道:
> > >>>>> * 王洪亮 <wanghongliang@...ngson.cn> [2023-04-18 09:28:49 +0800]:
> > >>>>>> +++ b/arch/loongarch64/bits/signal.h
> > >>>>>> @@ -6,14 +6,27 @@
> > >>>>>> #define SIGSTKSZ 16384
> > >>>>>> #endif
> > >>>>>>
> > >>>>>> +#if defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
> > >>>>>> typedef unsigned long greg_t, gregset_t[32];
> > >>>>>>
> > >>>>>> -typedef struct sigcontext {
> > >>>>>> +struct sigcontext {
> > >>>>>> unsigned long sc_pc;
> > >>>>>> - gregset_t sc_regs;
> > >>>>>> - unsigned int sc_flags;
> > >>>>>> - unsigned long sc_extcontext[];
> > >>>>>> + unsigned long sc_regs[32];
> > >>>>>> + unsigned int sc_flags;
> > >>>>>> + unsigned long sc_extcontext[] __attribute__((__aligned__(16)));
> > >>>>>> +};
> > >>>>> this looks good. (i don't know if this is really
> > >>>>> needed in signal.h, but other targets have it too)
> > >>>>>
> > >>>>>> +
> > >>>>>> +typedef struct {
> > >>>>>> + unsigned long __pc;
> > >>>>>> + unsigned long __gregs[32];
> > >>>>>> + unsigned int __flags;
> > >>>>>> + unsigned long __extcontext[] __attribute__((__aligned__(16)));
> > >>>>>> } mcontext_t;
> > >>>>> i would use the same struct tag as glibc so
> > >>>>>
> > >>>>> typedef struct mcontext_t { ...
> > >>>>>
> > >>>>> (we don't need c++ abi compat with glibc, but
> > >>>>> it's nicer to be consistent)
> > >>>>>
> > >>>>>> +#else
> > >>>>>> +typedef struct {
> > >>>>>> + unsigned long __space[34];
> > >>>>>> +} mcontext_t;
> > >>>>> i would add the aligned attribute here.
> > >>>>>
> > >>>>> (it's more important to match the kernel layout than to
> > >>>>> avoid c extensions in standard mode: loongarch c compilers
> > >>>>> will all support the aligned attribute in system headers)
> > >>>> I understand there is no need for me to submit modifications,
> > >>>> you help me modify it directly,right?
> > >>>>>> +#endif
> > >>>>>>
> > >>>>>> struct sigaltstack {
> > >>>>>> void *ss_sp;
> > >>>>>> @@ -23,11 +36,10 @@ struct sigaltstack {
> > >>>>>>
> > >>>>>> typedef struct __ucontext
> > >>>>>> {
> > >>>>>> - unsigned long uc_flags;
> > >>>>>> + unsigned long __uc_flags;
> > >>>>>> struct __ucontext *uc_link;
> > >>>>>> stack_t uc_stack;
> > >>>>>> sigset_t uc_sigmask;
> > >>>>>> - long __uc_pad;
> > >>>>>> mcontext_t uc_mcontext;
> > >>>>>> } ucontext_t;
> > >>>>> looks good.
> > >>>>>
> > >>>>> (the only issue is if some code uses uc_flags in an
> > >>>>> arch independent way. i don't know if there is any
> > >>>>> use for it on linux. but we can fix that later on
> > >>>>> both glibc and musl side if it comes up.)
>
>
> 本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。
> This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
