Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 21 Jun 2023 11:04:14 -0400
From: Rich Felker <dalias@...c.org>
To: Yonggang Luo <luoyonggang@...il.com>
Cc: Jens Gustedt <jens.gustedt@...ia.fr>, enh <enh@...gle.com>,
	musl@...ts.openwall.com
Subject: Re: [PATCH v3 3/5] add pthread_mutex_clocklock and
 pthread_cond_clockdwait

On Tue, Jun 20, 2023 at 10:37:01PM +0800, Yonggang Luo wrote:
> These two functions are already implemented in glibc, android bionic libc, qnx libc
> 
> Signed-off-by: Yonggang Luo <luoyonggang@...il.com>
> ---
>  compat/time32/pthread_cond_clockwait_time32.c  |  9 +++++++++
>  compat/time32/pthread_mutex_clocklock_time32.c |  9 +++++++++
>  compat/time32/time32.h                         |  2 ++
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

...

> --- a/include/pthread.h
> +++ b/include/pthread.h
> [...]
>  
>  #if _REDIR_TIME64
> +__REDIR(pthread_mutex_clocklock, __pthread_mutex_clocklock_time64);
>  __REDIR(pthread_mutex_timedlock, __pthread_mutex_timedlock_time64);
> +__REDIR(pthread_cond_clockwait, __pthread_cond_clockwait_time64);

None of this is needed. There only exist redirections and legacy
time32 functions for symbols which existed in the ABI with 32-bit
time_t. Any newly added functions are time64 from day one.

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.