Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 18 Apr 2023 12:47:31 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: 王洪亮 <wanghongliang@...ngson.cn>,
	musl@...ts.openwall.com
Subject: Re: add loongarch64 port v7.

* Szabolcs Nagy <nsz@...t70.net> [2023-04-18 11:38:44 +0200]:
> * 王洪亮 <wanghongliang@...ngson.cn> [2023-04-18 09:28:49 +0800]:
> > +typedef struct {
> > +    unsigned long __pc;
> > +    unsigned long __gregs[32];
> > +    unsigned int __flags;
> > +    unsigned long __extcontext[] __attribute__((__aligned__(16)));
> >  } mcontext_t;
> 
> i would use the same struct tag as glibc so
> 
> typedef struct mcontext_t { ...
> 
> (we don't need c++ abi compat with glibc, but
> it's nicer to be consistent)

sorry this is wrong, c++ abi is same for

  typedef struct foo {} foo;

and

  typedef struct {} foo;

so we don't need to change the code to match glibc:
untagged struct types use the typename for mangling
so it's mcontext_t either way.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.