Date: Sun, 30 Oct 2022 06:29:54 +0000 From: puwenxu <puwenxu1@...wei.com> To: "musl@...ts.openwall.com" <musl@...ts.openwall.com> Subject: Question on 2b2c8aafce9d80f9d58652643538f4d58e82b856 Dear maintainer, I'm using musl 220.127.116.11 now. When I was running some test case codes for musl, I found there may be a problem on modification of 2b2c8aafce9d80f9d58652643538f4d58e82b856. As you can see in the picture, this modification assign buf to orig. Then, the orig will be assigned to buf again. If the original value of buf is NULL, the latter value of the buf will be NULL. However, assign out to buf will fail if buf is NULL. [cid:image001.png@...8EC6C.12AE8540] I have written a simple file to verification my opinion. The test code and output is shown in the following picture. I think it may be better to add a check for buf in this situation. [cid:image002.png@...8EC6C.12AE8540] [cid:image003.png@...8EC6C.12AE8540] Looking forward to your reply. Wish Pu OS Kernel Lab Content of type "text/html" skipped Download attachment "image001.png" of type "image/png" (100094 bytes) Download attachment "image002.png" of type "image/png" (101290 bytes) Download attachment "image003.png" of type "image/png" (4073 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.