Date: Fri, 28 Oct 2022 14:20:50 +0000 From: puwenxu <puwenxu1@...wei.com> To: "musl@...ts.openwall.com" <musl@...ts.openwall.com> Subject: Questions on commit 98e688a9da5e7b2925dda17a2d6820dddf1fb287 Dear maintainer, As you can see in the pictures, the commit 98e688a9da5e7b2925dda17a2d6820dddf1fb287 modified the codes related to macro __cpluscplus. [cid:image005.png@...8EB1B.83A5DFC0] During my usage of musl, I found that if the macro __cplusplus had not been defined, the compilation will fail, and report error on __cplusplus. I am very puzzled about this commit, I think this modification doesn't take the condition that the __cplusplus hasn't been defined into consideration. I'm eager to know why. In order to continue my job immediately, I modify the codes like the picture below. As far as I'm concerned, before using __cpluscplus, we should judge whether it has been defined. Attached is my full patch. [cid:image006.png@...8EB1B.83A5DFC0] I'm looking forward to your reply. Wish Pu OS kernel lab Content of type "text/html" skipped Download attachment "image005.png" of type "image/png" (168625 bytes) Download attachment "image006.png" of type "image/png" (232707 bytes) Download attachment "0001-musl-Upgrade-musl.patch" of type "application/octet-stream" (3357 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.