Date: Mon, 15 Aug 2022 15:07:46 -0300 From: Érico Nogueira <ericonr@...root.org> To: musl@...ts.openwall.com Cc: Érico Nogueira <ericonr@...root.org> Subject: [PATCH] make exit condition clearer in fixup_rpath breaking out of the switch-case when l==-1 means the conditional below will necessarily be true (-1 >= buf_size, a size_t variable) and the function will return 0. it is, however, somewhat unclear that that's what's happening. simply returning there is simpler --- ldso/dynlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ldso/dynlink.c b/ldso/dynlink.c index cc677952..fb77b092 100644 --- a/ldso/dynlink.c +++ b/ldso/dynlink.c @@ -868,7 +868,7 @@ static int fixup_rpath(struct dso *p, char *buf, size_t buf_size) case ENOENT: case ENOTDIR: case EACCES: - break; + return 0; default: return -1; } -- 2.37.2
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.