Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 15 May 2022 19:19:29 -0400
From: Rich Felker <>
To: Alyssa Ross <>
Subject: Re: [PATCH musl v2 3/3] mntent: fix parsing lines with
 optional fields

On Sun, May 15, 2022 at 06:38:40PM +0000, Alyssa Ross wrote:
> Hi Rich,
> On Thu, May 12, 2022 at 02:15:53PM -0400, Rich Felker wrote:
> > Alright. It sounds like your patch is pretty much okay as-is except
> > for the added " || n[1]==len" in the while condition and removing the
> > (now unreachable) return-zero condition at the end. If that sounds
> > right and it's okay with you I'm happy to commit your existing patch
> > with those changes then make any other improvements myself or review
> > further patches from you separately if you like. What do you think?
> Sounds good.  Please go ahead and do it yourself —-it would take me a
> fair bit of time to put my Musl development setup back together, so if
> you're happy to fix up and commit the patch there's no point in me
> doing that.

One more thing I missed: checking result of sscanf for EOF and
ferror(f) does not make sense; that would only make sense if it were
fscanf, but the FILE access already happened and was checked earlier.
Any objection to me just also removing that from the patch?


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.