Date: Tue, 26 Apr 2022 22:13:21 -0400 From: Rich Felker <dalias@...c.org> To: 王洪亮 <wanghongliang@...ngson.cn> Cc: musl@...ts.openwall.com Subject: Re: Re: add loongarch64 port On Wed, Apr 27, 2022 at 09:58:44AM +0800, 王洪亮 wrote: > > 在 2022/3/31 下午4:14, Arnd Bergmann 写道: > >The __NR_fstat and __NR_newfstatat symbols are only defined by > >the kernel if __ARCH_WANT_NEW_STAT is set, which should not be > >by the time the kernel port is merged. Instead, user space should > >call statx() here, which continues to be supported as a superset. > > > > > > Arnd > > there is a build error if I remove __NR_fstat and __NR_newfstatat, > the architecture-independent code depends on the __NR_fstat and > __NR_fstatat defined in architecture platform. > How to deal with this issue? > > In file included from src/stat/fstatat.c:8: > src/stat/fstatat.c: In function ‘fstatat_kstat’: > src/stat/fstatat.c:78:19: error: ‘SYS_fstat’ undeclared (first use > in this function); did you mean ‘SYS_statx’? > ret = __syscall(SYS_fstat, fd, &kst); > > src/stat/fstatat.c:80:20: error: ‘SYS_fstatat’ undeclared (first use > in this function); did you mean ‘SYS_fstatfs’? > > ret = __syscall(SYS_fstatat, fd, path, &kst, flag); There are pending changes that are needed for riscv32 that address the same issue there. I'll review them again in the next couple days and either merge them or make alternative changes to make the rest of musl not assume the existence of these syscalls. Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.