Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 8 Mar 2022 17:16:08 -0500
From: Rich Felker <dalias@...c.org>
To: Alexey Kodanev <aleksei.kodanev@...l-sw.com>
Cc: musl@...ts.openwall.com
Subject: Re: [PATCH] nice: return EPERM instead of EACCES

On Tue, Aug 03, 2021 at 12:18:15PM +0300, Alexey Kodanev wrote:
> On 29.06.2021 23:10, Rich Felker wrote:
> > On Tue, Jun 29, 2021 at 06:45:42PM +0300, Alexey Kodanev wrote:
> >> On 29.06.2021 17:48, Rich Felker wrote:
> >>> Is there actually an issue here? setpriority is specified to fail with
> >>> EACCES already for this case; EPERM is only specified for targeting
> >>> other processes you don't have permission to target. Is Linux getting
> >>> this wrong for setpriority?
> >>
> >> No, it's fine for setpriority(), it just seems wrong for nice()
> >> to return EACCES in this case.
> >>
> >> LTP/nice04 test (setting nice(-10)) is failing with musl and POSIX
> >> indeed says that the errno should be EPERM, for nice().
> > 
> > Oh, sorry, I read it backwards and was thinking it was replacing EPERM
> > with EACCES. Indeed nice is supposed to return EPERM where setpriority
> > would return EACCES so I think this patch is correct.
> > 
> 
> Hi Rich,
> 
> I wonder what is the status of this patch, didn't find it in git... is
> there any issue with it?

Sorry I overlooked this for so long! I'm merging it now.

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.