Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 13 Feb 2022 10:54:23 +0200
From: Yuri Kanivetsky <yuri.kanivetsky@...il.com>
To: Rich Felker <dalias@...c.org>
Cc: Markus Wichmann <nullplan@....net>, musl@...ts.openwall.com
Subject: Re: What determines the TERM variable value?

I don't think it's configurable in a common sense:

https://github.com/moby/moby/blob/v20.10.12/container/container.go#L752

But you can do:

$ docker run --rm -it -e TERM=xterm-256color alpine
/ # echo $TERM
xterm-256color

So, to sum it up, a terminal emulator is a program (let's not bring up
virtual consoles here) that emulates a terminal. It creates a pty (a
master/slave pair), drawing in a window what it receives from the pty,
and sending what user types to the pty. It also processes some escape
sequences it receives from the pty, and transforms some user
keystrokes into escape sequences before sending them to the pty. And
that determines the TERM variable value (for it to work correctly
you've got to have it set to a correct value).

Then there are some programs like screen and tmux, that are not
strictly terminal emulators, but in a way they are. They also create a
pty, and translate escape sequences from the "language" they
understand to the "language" understood by what's up the chain
(according to TERM), and vice versa. And again you've got to keep TERM
to a fixed range of values for it to work correctly.

Then there're some programs like ssh that create a pty, but doesn't change TERM.

And programs like docker that create a pty, but change TERM.

https://github.com/moby/moby/commit/c85db1003b#diff-14bacfb63a209323729af295c64c9bb978c84e810d18e3e7b7ae66d9b3cd7acaR259

Most likely to be user friendly. To make it work automagically for
users with an uncommon TERM value. I'd say it makes it more confusing
this way, but well, probably not everybody would agree.

So, basically with programs like ssh and docker, you generally want to
keep TERM unchanged. Granted that the corresponding terminfo entry
exists on a server/in a container.

But why would a program like ssh or docker want to create a pty in the
first place? If a pty on its own is just a data channel, then they
could just pass data as is, letting a terminal emulator handle things.
Isn't having TERM set enough for the programs down the chain to see
that they're connected to a terminal?

On Sat, Feb 12, 2022 at 5:05 PM Rich Felker <dalias@...c.org> wrote:
>
> On Sat, Feb 12, 2022 at 11:33:56AM +0100, Markus Wichmann wrote:
> > On Sat, Feb 12, 2022 at 11:34:52AM +0200, Yuri Kanivetsky wrote:
> > > So, a program is a terminal emulator if it translates escape sequences
> > > in both directions? And if it, as a result, changes the TERM variable?
> > >
> >
> > A program is a terminal emulator if it emulates a terminal, i.e.
> > provides an interface for TUI applications to interact with a keyboard
> > and screen (and optionally a mouse). The Linux VT provides such a thing
> > directly, X11 applications like xterm do so via the X11 protocol. Screen
> > and tmux are men in the middle, implementing screen and keyboard via
> > another terminal emulator. But still, they are terminal emulators.
> >
> > The TERM variable is not somehow especially protected. Any process can
> > change it at any time, and it will remain changed for that process and
> > any child processes until one of those decides to change it again. To
> > wit:
> >
> > > What seems strange to me is that docker changes the TERM variable:
> > >
> > > $ echo $TERM
> > > screen-256color
> > >
> > > $ docker run --rm -it alpine
> > > / # echo $TERM
> > > xterm
> > >
> >
> > Anyone can change the TERM variable, including docker. I think, they
> > assume that xterm is a least common denominator among terminal
> > emulators. Also, the xterm terminfo is most likely to be installed in
> > whatever container you are running.
>
> If that's what's happening, Docker is just wrong to be doing this.
> xterm is one of the most over-featured terminals out there, and the
> terminfo for it reflects that. TERM=xterm is not likely to actually
> work for most terminals if the application actually tries to make use
> of any of the advanced features (though it might appear to work as
> long as they stick to basics).
>
> The appropriate TERM setting for a minimal common denominator where
> you don't know the actual terminal type is probably something like
> vt102 or vt220. But really Docker just shouldn't munge it.
>
> > That said, docker is a highly flexible piece of software, so I would be
> > surprised if this functionality was not configurable somehow.
>
> Yeah, it's probably configurable.
>
> Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.