Date: Sun, 15 Aug 2021 19:36:55 +0200 From: Ismael Luceno <ismael@...ev.co.uk> To: musl@...ts.openwall.com Cc: Rich Felker <dalias@...c.org> Subject: Re: [PATCH] glob: implement GLOB_NOMAGIC On 27/Jul/2019 15:59, Ismael Luceno wrote: > On 26/Jul/2019 22:39, Rich Felker wrote: > <...> > > The documentation for this flag is really poor. Do you know how it's > > supposed to interact with escaped characters? Is it really supposed to > > refuse to expand to the literal pattern when the literal pattern > > contains an escaped *, ?, or [ but not a special one? > > It's intended for implementing csh-style globbing, which doesn't > recognize escaping. > > I don't see any reason to enforce GLOB_NOESCAPE, though. > > > Otherwise I think this looks ok. Nice use of strcspn. > > :-). Ping. This is used in combination with GLOB_NOESCAPE by csh implementations to implement their globbing behavior; I added it for completeness, it's very small, and it saves quite some disk space in the csh binary, by not having to bundle another glob implementation. While AFAIK it's always used in combination with GLOB_NOESCAPE, I see no reason to enforce that.
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.