Date: Wed, 19 May 2021 09:54:00 +0200 From: Arnd Bergmann <arnd@...nel.org> To: musl@...ts.openwall.com Cc: Khem Raj <raj.khem@...il.com>, zabolcs Nagy <nsz@...t70.net> Subject: Re: [PATCH] riscv: Rename __NR_fstatat __NR_newfstatat On Wed, May 19, 2021 at 9:34 AM Khem Raj <raj.khem@...il.com> wrote: > > on riscv64 this syscall is called __NR_newfstatat > this helps the name match kernel UAPI for external > programs > > Signed-off-by: Khem Raj <raj.khem@...il.com> > Cc: zabolcs Nagy <nsz@...t70.net> This looks correct to me. Unfortunately the kernel's definitions for the stat family are inconsistent in a lot of different ways, and the naming between fstat and newfstatat is just one more instance of this. In theory, the 'new' macros refer to the kernel's "struct stat", while the non-prefixed ones refer to the syscalls taking "struct __kernel_old_stat". Comparing the riscv64 file to the aarch64 version shows that the aarch64 version matches what the kernel defines, no idea why the riscv64 version is different. Arnd
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.